chore: removed extra navigation screen #5391
Conversation
github-actions
bot
added
🤗 Onboarding
sohamkolhe9829
changed the title
sohamkolhe9829
changed the title
There was a problem hiding this comment.
Hi @sohamkolhe9829!
Please revert to intl:0.18.1 as we're still using flutter 3.19 (and it's incompatible).
Btw don't use the ^ syntax either.
There was a problem hiding this comment.
Hi @sohamkolhe9829!
Beyond the pubspec.yaml (that still isn't fixed), I assume that there should be deleted files and delete enum values in your PR, as we remove a page, and it's not the case...
packages/smooth_app/pubspec.lock
Outdated
| url: "https://pub.dev" | ||
| source: hosted | ||
| version: "0.18.1" | ||
| version: "0.19.0" |
There was a problem hiding this comment.
Probably because of the ^.
|
The disadvantage of 2 features in a single PR is when we only want a part of it. |
|
@sohamkolhe9829 btw I would advise you to create and use branches and not to send PR from the main |
|
how to do that, can you help me out?
…On Mon, 17 Jun 2024 at 11:40, monsieurtanuki ***@***.***> wrote:
@sohamkolhe9829 <https://github.com/sohamkolhe9829> btw I would advise
you to create and use branches and not to send PR from the main develop
branch.
—
Reply to this email directly, view it on GitHub
<#5391 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4E7ETHWG63MDQPQT2WSKPDZHZ4WNAVCNFSM6AAAAABJMVBZYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZSGM3DKMBZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I'm afraid not, I'm not very good with github. But you can find specific help about it on the web. |
That's not that hard.
|
Co-authored-by: monsieurtanuki <[email protected]>
g123k
changed the title
|
@sohamkolhe9829 I'm going to close, since @g123k had something that covers the same score. sorry for this one. Sorry for the mishap. |
What
Screenshot
Fixes bug(s)
Part of